jc

Results 29 comments of jc

> any unit test for this modification? 没有修改单元测试,只是修改了下逻辑并且抽出来一些共用的方法

need to resolve the code conflict

`len(a.opts.afterStop) != 0` doesn't make sense?

> I think the issue is that nil slice and empty slice are different things and some APIs may require one or another. CC @cristaloleg Yes, but I need to...

> golang/go/wiki/CodeReviewComments#declaring-empty-slices [golang wiki](https://github.com/golang/go/wiki/CodeReviewComments#declaring-empty-slices) In most cases, empty slices, simply stating that a nil slice is sufficient

> > Yes, but I need to detect some empty slices that are not necessary and if not, nolint skips > > Sounds like a too opinionated. I understand you...

![image](https://user-images.githubusercontent.com/27986239/231642545-4c5cd32d-2a82-40ae-a7b2-149a97555af3.png) ![image](https://user-images.githubusercontent.com/27986239/231642570-b12b7f16-8d56-4462-816d-1a2b2122457c.png) ![image](https://user-images.githubusercontent.com/27986239/231642588-d56fa183-2780-48ff-884b-10e25dcacfb1.png)

hello @cristaloleg , https://github.com/go-critic/go-critic/pull/1337 Do you mean to add it here?

> I've removed go 1.11 specific instructions but I'm unsure whether updating `go.mod` to include 1.13 is a good idea, do let me know what you think! I think it...