jc
jc
> any unit test for this modification? 没有修改单元测试,只是修改了下逻辑并且抽出来一些共用的方法
need to resolve the code conflict
`len(a.opts.afterStop) != 0` doesn't make sense?
@quasilyte PTAL
> I think the issue is that nil slice and empty slice are different things and some APIs may require one or another. CC @cristaloleg Yes, but I need to...
> golang/go/wiki/CodeReviewComments#declaring-empty-slices [golang wiki](https://github.com/golang/go/wiki/CodeReviewComments#declaring-empty-slices) In most cases, empty slices, simply stating that a nil slice is sufficient
> > Yes, but I need to detect some empty slices that are not necessary and if not, nolint skips > > Sounds like a too opinionated. I understand you...
  
hello @cristaloleg , https://github.com/go-critic/go-critic/pull/1337 Do you mean to add it here?
> I've removed go 1.11 specific instructions but I'm unsure whether updating `go.mod` to include 1.13 is a good idea, do let me know what you think! I think it...