content icon indicating copy to clipboard operation
content copied to clipboard

ShadowX SOCAI Partner Pack (v1.1.0)Feat/shadowx socai

Open shadowx-socai opened this issue 1 month ago • 2 comments

Thank you for the detailed review! I have addressed all your feedback in this latest commit:

Code & Logic:

API Key: Switched to type: 9 (Credentials) and removed the old type: 4 logic.

Cookie Mode: Completely removed all old code, parameters, and helpers related to cookie/HTML login. The integration now strictly uses the API Key (Bearer token).

Paths: Removed API path parameters from the YML and hardcoded them as constants in the Python script.

Error Handling: Replaced generic except Exception blocks with specific json.JSONDecodeError handling and added debug logging.

Unit Tests: Added a comprehensive ShadowxSOCAI_test.py file with mock tests for submit and get commands.

Documentation & Assets:

Images: Resized both Author_image.png and ShadowxSOCAI_image.png to exactly 120x50 pixels.

YML: Added descriptions for all outputs and added command examples to the YML file.

Pack README: Deleted all content from the root Packs/ShadowxSOCAI/README.md (file is now empty).

Integration README: Re-generated the documentation using demisto-sdk generate-docs.

Release Notes: Deleted the ReleaseNotes files (kept the folder).

shadowx-socai avatar Nov 25 '25 08:11 shadowx-socai

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @merit-maita will know the proposed changes are ready to be reviewed. For your convenience, here is a link to the contributions SLAs document.

content-bot avatar Nov 25 '25 08:11 content-bot

Hi @shadowx-socai, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

content-bot avatar Nov 25 '25 08:11 content-bot