content icon indicating copy to clipboard operation
content copied to clipboard

[Marketplace Contribution] Microsoft Sentinel -Fix Watchlist Items Pagination by Adding Support for next_link

Open xsoar-bot opened this issue 2 months ago • 7 comments

Status

  • [x] In Progress
  • [ ] Ready
  • [ ] In Hold - (Reason for hold)

Contributor

@ispRM

Auto-Generated Documentation Requiring Modification

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

xsoar-bot avatar Oct 29 '25 14:10 xsoar-bot

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @merit-maita will very shortly look over your proposed changes. For your convenience, here is a link to the contributions SLAs document.

content-bot avatar Oct 29 '25 15:10 content-bot

Thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution, please ask the reviewer to update your information in the pack contributors file. See more information here link

content-bot avatar Oct 29 '25 15:10 content-bot

Thanks for submitting your PR! Before moving on with the detailed review, please take a moment to address a few general comments below.

  • The PR description is too generic. Please update the PR title and description to clearly articulate the main changes, such as the enhancement to azure-sentinel-list-watchlist-items with the addition of a 'limit' argument. This will help reviewers understand the scope and impact of your changes more effectively.

Hi, thanks for the feedback.

I’m not able to edit the PR title or description because this submission was created directly through XSOAR’s marketplace contribution flow, so I don’t have permission to modify the PR metadata.

To clarify the change: the update adds the missing logic to follow the next_link when listing watchlist items. Without this, the command only retrieves the first 100 items of a watchlist, with no way to request more. My modification aligns this command with the pagination logic already used in other parts of the same integration, allowing all items in a watchlist to be retrieved correctly.

If needed, feel free to update the PR title and description accordingly.

ispRM avatar Nov 17 '25 16:11 ispRM

Hi @mayyagoldman

Thanks very much for the careful review and guidance, it is really appreciated!
All unwanted changes carried over from the XSOAR Marketplace contribution have been removed and all suggestions have been applied.

ispRM avatar Nov 19 '25 17:11 ispRM

@ispRM Looks great — thanks for making the updates! The only thing I think is still missing is support for the next_link argument, which lets the user skip previously retrieved results and continue querying from that point.

See the first part of my earlier comment for details. Let me know if you have any questions or if anything isn’t working — I’m happy to help!

mayyagoldman avatar Nov 20 '25 09:11 mayyagoldman

Hi @mayyagoldman, please let me know if everything looks good now. Thank you!

ispRM avatar Nov 21 '25 09:11 ispRM

Hi @mayyagoldman any update? thanks

ispRM avatar Nov 28 '25 09:11 ispRM