content icon indicating copy to clipboard operation
content copied to clipboard

GR110 - Validate existence of inputs and outputs - fixes

Open michal-dagan opened this issue 2 months ago • 13 comments

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • [x] In Progress
  • [ ] Ready
  • [ ] In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

sdk PR - https://github.com/demisto/demisto-sdk/pull/5134 ctc MR - https://gitlab.xdr.pan.local/xdr/cortex-content/content-test-conf/-/merge_requests/2646

michal-dagan avatar Oct 19 '25 14:10 michal-dagan

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CommonScripts/Scripts/SearchIndicatorAgentix
   SearchIndicatorAgentix.py89396%60–61, 139
Packs/Core/Integrations/CortexPlatformCore
   CortexPlatformCore.py6479285%411–412, 414–415, 417, 469–472, 474, 476, 489, 492, 506, 509, 516, 519, 526, 533, 551, 558, 561, 569, 574, 584–585, 633, 653, 785, 788, 790, 889, 1018–1022, 1087–1088, 1262–1265, 1268–1278, 1280, 1288, 1295–1297, 1299–1300, 1313–1317, 1324–1326, 1328, 1338, 1363–1365, 1372–1373, 1375–1380, 1382–1384, 1386, 1423, 1709–1711, 1795–1796
Packs/Core/Scripts/CoreQuarantineFiles
   CoreQuarantineFiles.py8275%9–10
Packs/Core/Scripts/CoreUnisolateEndpoint
   CoreUnisolateEndpoint.py8275%9–10
Packs/Gmail/Integrations/Gmail
   Gmail.py130178239%62–64, 67–70, 73–74, 77–80, 83–86, 89–90, 93–95, 97–98, 101, 105–111, 116–124, 131, 146–150, 152–156, 160–165, 253, 261, 299, 348, 354, 415–419, 446, 474, 478, 491, 506, 552–554, 557, 560–562, 564, 621, 844–850, 854–855, 857–860, 862, 866–867, 869, 873, 875–879, 887–889, 893, 900–903, 905–906, 912–915, 917–921, 923, 927–930, 932–934, 936, 946–956, 958, 961, 965–968, 983, 994–995, 997–999, 1003–1007, 1009–1010, 1014, 1019–1020, 1022–1023, 1025, 1029–1032, 1034, 1038, 1045–1046, 1048, 1052–1056, 1060, 1067–1068, 1070, 1074–1075, 1077, 1079, 1083, 1085, 1096–1097, 1101, 1103–1117, 1119, 1131, 1145, 1159–1160, 1162, 1165–1166, 1170–1173, 1177–1180, 1184, 1187–1188, 1195–1196, 1199, 1201–1202, 1206–1210, 1212–1213, 1215–1216, 1220, 1230–1231, 1233, 1237–1238, 1240, 1244, 1248–1249, 1251, 1255–1258, 1262–1264, 1266–1267, 1269–1270, 1274, 1279, 1287, 1289, 1291, 1295, 1297, 1306, 1310–1312, 1314–1315, 1317–1318, 1322, 1324–1325, 1327–1328, 1332, 1337–1338, 1340–1341, 1345–1347, 1349, 1351, 1355, 1359–1360, 1362, 1373–1380, 1382–1385, 1389–1392, 1394–1396, 1399–1400, 1403, 1406–1409, 1414, 1417–1419, 1424–1425, 1432, 1434–1442, 1444–1451, 1453–1456, 1474–1477, 1480–1487, 1508, 1518–1519, 1521, 1529, 1531–1535, 1537, 1540–1541, 1543, 1545, 1549–1553, 1555–1561, 1565, 1570–1571, 1574, 1576, 1580–1582, 1584, 1586, 1590, 1595–1597, 1599, 1603–1609, 1613–1617, 1619–1620, 1624, 1632–1633, 1635, 1639–1642, 1644, 1646–1647, 1652, 1655, 1661–1662, 1665, 1667, 1671–1674, 1676, 1680, 1685, 1691–1693, 1695–1696, 1700, 1702–1704, 1706, 1708, 1712, 1714–1715, 1717, 1721, 1723–1725, 1727, 1735, 1739, 1741–1754, 1756, 1770, 1786, 1794–1813, 1815–1816, 1818, 1822, 1824–1827, 1829, 1831, 1835, 1838–1842, 1844, 1848, 1850–1853, 1855–1856, 1858, 1862, 1864–1865, 1867, 1877–1878, 1898–1899, 1906–1907, 1912, 1916–1917, 1919–1920, 1922–1923, 1925–1928, 1930–1932, 1934, 1936, 1938, 1980–1984, 1986–1989, 1991–1993, 1995, 1999–2000, 2004–2006, 2008–2012, 2014–2016, 2018–2019, 2021, 2023, 2030–2037, 2040, 2042–2044, 2046, 2048–2051, 2054–2055, 2062–2067, 2070–2071, 2073–2079, 2082–2083, 2085–2089, 2092–2093, 2095–2099, 2101–2102, 2105–2109, 2112–2113, 2140–2144, 2149, 2152, 2158–2161, 2180, 2182, 2186–2187, 2189–2194, 2198–2200, 2202–2204, 2206–2207, 2210–2212, 2232–2233, 2237–2257, 2259, 2282, 2284–2286, 2291–2292, 2296–2298, 2300, 2313–2324, 2345–2346, 2363, 2387–2397, 2399, 2422–2423, 2445, 2472–2473, 2475, 2477, 2479, 2481–2485, 2487–2490, 2492–2493, 2495, 2497, 2505, 2532, 2543–2544, 2579–2581, 2606–2607, 2618–2619, 2666–2667, 2671, 2681, 2692–2694, 2698–2700, 2709, 2723–2724
Packs/Microsoft365Defender/Integrations/Microsoft365Defender
   Microsoft365Defender.py43911374%74–77, 140, 142–143, 145–148, 150–152, 155–157, 160–162, 164–165, 167–168, 170, 206, 214–216, 219, 236–237, 255, 262–263, 268–269, 292, 314, 346–347, 350, 446–449, 462, 497, 637, 660, 846–847, 892–893, 944, 948–949, 961–962, 967–970, 979–985, 1041–1042, 1103–1104, 1107, 1178–1179, 1181–1182, 1184–1185, 1187–1188, 1190–1192, 1194–1196, 1198–1200, 1202–1204, 1206–1210, 1212–1214, 1216–1219, 1221–1223, 1225–1226, 1229
Packs/MicrosoftDefenderAdvancedThreatProtection/Scripts/MicrosoftAtpUnisolateMachine
   MicrosoftAtpUnisolateMachine.py8275%9–10
TOTAL250099660% 

Tests Skipped Failures Errors Time
244 0 :zzz: 0 :x: 0 :fire: 16.444s :stopwatch:

github-actions[bot] avatar Oct 19 '25 14:10 github-actions[bot]

This PR was automatically updated by a GitHub Action

  • ServiceNow pack version was bumped to 2.8.15.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

content-bot avatar Oct 21 '25 10:10 content-bot

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.20.25.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

content-bot avatar Oct 22 '25 08:10 content-bot

This PR was automatically updated by a GitHub Action

  • Core pack version was bumped to 3.4.49.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

content-bot avatar Nov 18 '25 16:11 content-bot

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.20.40.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

content-bot avatar Nov 18 '25 17:11 content-bot

This PR was automatically updated by a GitHub Action

  • Core pack version was bumped to 3.4.50.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

content-bot avatar Nov 19 '25 09:11 content-bot

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.20.41.
  • Core pack version was bumped to 3.4.51.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

content-bot avatar Nov 19 '25 12:11 content-bot

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.20.42.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

content-bot avatar Nov 19 '25 15:11 content-bot

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.20.43.
  • Microsoft365Defender pack version was bumped to 4.6.24.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

content-bot avatar Nov 20 '25 09:11 content-bot

This PR was automatically updated by a GitHub Action

  • Core pack version was bumped to 3.4.52.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

content-bot avatar Nov 20 '25 12:11 content-bot

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.20.44.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

content-bot avatar Nov 23 '25 16:11 content-bot

This PR was automatically updated by a GitHub Action

  • Core pack version was bumped to 3.4.53.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

content-bot avatar Nov 24 '25 16:11 content-bot

Validate summary The following errors were thrown as a part of this pr: BC101, BC102. The following errors cannot be ignored: BC101, BC102. If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged. The following errors don't run as part of the nightly flow and therefore can be force merged: BC101, BC102.

Verdict: PR can be force merged from validate perspective? ✅

content-bot avatar Dec 01 '25 17:12 content-bot

force-merge:

  • Packs/Microsoft365Defender/Integrations/Microsoft365Defender/Microsoft365Defender.yml: [BC102] - Changing output context paths is not allowed. Restore the following outputs: In the microsoft-365-defender-advanced-hunting command, the following outputs are missing for backward-compatability: Microsoft365Defender.Hunt.results.

  • Packs/MicrosoftDefenderAdvancedThreatProtection/Scripts/MicrosoftAtpUnisolateMachine/MicrosoftAtpUnisolateMachine.yml: [BC101] - The following output keys: MicrosoftATP.Machine.ID. Has been removed, please undo.

  • Packs/Core/Scripts/CoreUnisolateEndpoint/CoreUnisolateEndpoint.yml: [BC101] - The following output keys: Core.Isolation.endpoint_id. Has been removed, please undo.

  • Packs/CommonScripts/Scripts/SearchIndicatorAgentix/SearchIndicatorAgentix.yml: [BC101] - The following output keys: foundIndicators.investigationIDs. Has been removed, please undo.

  • TPBs failed on xsoar-ng as Gmail Integration commands can't parse token, will reopen this ticket: https://jira-dc.paloaltonetworks.com/browse/CIAC-12587

michal-dagan avatar Dec 02 '25 08:12 michal-dagan