Armis Release 1.2.1

[crestdatasystems]

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

• [ ] In Progress
• [x] Ready
• [ ] In Hold - (Reason for hold)

Description

Armis Event Collector

• Updated the API read timeout to 3 minutes to reduce overall request failures.
• Updated the value of includeTotal API parameter to false to improve performance.

Must have

• [x] Tests
• [x] Documentation

[content-bot]

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @itssapir will know the proposed changes are ready to be reviewed. For your convenience, here is a link to the contributions SLAs document.

[content-bot]

Hi @crestdatasystems, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

[crestdatasystems]

Hi @crestdatasystems, Thank you for your contribution!

Could you please clarify what it means when includeTotal is set to false? Specifically:

• Does this mean that less data will be returned to the user?
• Is there any impact on backward compatibility that we should be aware of?

Please feel free to reach out to me with any questions - I'm available here or on slack :) Thanks again

Hi @itssapir, Thanks for reviewing the PR.

The intention to set the includeTotal to false is to not return the total count of the records. If set to true, API computes to get the total count of the records which increases delay of the API call. Also, this doesn't have any impact on the code which is parsing the API response.

[github-actions[bot]]

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.