content icon indicating copy to clipboard operation
content copied to clipboard

Jsontotable clickable links

Open Pinger77 opened this issue 7 months ago • 4 comments

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • [x] In Progress
  • [ ] Ready
  • [ ] In Hold - (Reason for hold)

Description

Add functionality to the JsonToTable script of the Filters And Transformers marketplace content pack that allows for the markdown table to contain values that have clickable URL links.

Must have

  • [ ] Tests
  • [ ] Documentation

Pinger77 avatar May 22 '25 17:05 Pinger77

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilappe will know the proposed changes are ready to be reviewed. For your convenience, here is a link to the contributions SLAs document.

content-bot avatar May 22 '25 17:05 content-bot

Hi @Pinger77, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

content-bot avatar May 22 '25 17:05 content-bot

Hi @Pinger77 Thanks for your contribution please see the validation error in addition, please share a short demo which show the usage of that improvements

reach me here if you need any help thanks in advance!

Thanks for the feedback! I added a new commit that is updating the docker image used for this automation.

Also, please see the attached quick recording, which is a demo of the improvements. Let me know if you need anything else!

https://github.com/user-attachments/assets/c3dabe94-a74d-440e-8f8a-c2b9df5b2bba

Pinger77 avatar May 28 '25 16:05 Pinger77

Hi @Pinger77 Thank you very much for your contribution & demo! Please note that during the upcoming week (1st - 2nd of June), we will not be available due to an Israeli holiday. So i will review it after the holiday. Thank you in advance for your patience and understanding.

ilappe avatar May 29 '25 13:05 ilappe

In the meantime, added the docs-approved label

julieschwartz18 avatar Jun 03 '25 12:06 julieschwartz18

For the Reviewer: Trigger build request has been accepted for this contribution PR.

content-bot avatar Jun 03 '25 12:06 content-bot

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/3620018

content-bot avatar Jun 03 '25 12:06 content-bot

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

github-actions[bot] avatar Jun 03 '25 13:06 github-actions[bot]