Added a support for V2 API for get-indicators-future-attack command
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
- [x] In Progress
- [ ] Ready
- [ ] In Hold - (Reason for hold)
Related Issues
Description
Added a support for V2 API for get-indicators-future-attack command
Must have
- [ ] Tests
- [x] Documentation
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilappe will know the proposed changes are ready to be reviewed. For your convenience, here is a link to the contributions SLAs document.
Hi @meghak-metron, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.
Hi @meghak-metron Thanks for your contribution! there is some validation error please go over, and try to fix them (there is a description of each of them) thanks in advance!
Hi @ilappe , Thanks for your response. We'll make the changes as per your comments and push the changes asap. Thanks!
Hi @meghak-metron
Thank you!
it's look like there is a ruff lint errors
can you please run demisto-sdk pre-commit in your repo? it should solve them
BTW
please note that during the upcoming week (1st - 2nd of June), we will not be available due to an Israeli holiday.
so i will happy to help & review after that.
thanks again!
demisto-sdk pre-commit
Hi @ilappe , Thanks for the reply. I have tried running the command demisto-sdk pre-commit, but I am still encountering the same error with pre-commit. Would it be possible to schedule a call today or tomorrow at your convenience to help resolve this issue?
Hi @ilappe,
We've resolved all the pre-commit errors and pushed the latest changes. Kindly review the PR at your earliest convenience.
If possible, we'd really appreciate a quick review, as the Silent Push-XSOAR app has already been published. A timely review would be a big help for us. Thanks in advance!
Hi @ilappe , I have fixed the pre-commit errors too, kindly review the PR.
discussed in Slack DFIR thanks @meghak-metron for your efforts!
Hi @ilappe As discussed earlier today, we have implemented all the required changes. All changes have passed the pre-commit tests successfully. From our end, everything is complete and ready. We kindly request you to review it at your earliest convenience. Also, thank you for your guidance and support.
Hi as discussed in Slack let's demo it tomorrow thanks!
Validation failed on BC102, but this are expected BC RN exist
@ilappe Thanks a lot for your help, we really appreciate your support!
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.