Improvement/implemented mirroring

[cyble-dev]

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

• [x] In Progress

Related Issues

fixes: Latency in incident population

Description

Implemented mirroring, made changed in the operation workflow and some buf fixes

Must have

• [x] Tests
• [x] Documentation

[CLAassistant]

All committers have signed the CLA.

[content-bot]

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilappe will know the proposed changes are ready to be reviewed. For your convenience, here is a link to the contributions SLAs document.

[content-bot]

Hi @cyble-dev, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

[cyble-dev]

@ilappe Can I request you to help with the PR feeback?

[ilappe]

@ilappe Can I request you to help with the PR feeback?

@cyble-dev thanks for your contribution! Sure, i'm on it

[ilappe]

Thank you very much for your contribution! Please note that during the upcoming week (1st - 2nd of June), we will not be available due to an Israeli holiday. Thank you in advance for your patience and understanding.

[cyble-dev]

@ilappe Can you please check again?

[ilappe]

Hi @cyble-dev it's look like there is still few issues:

• cla issue
• validation errors (failing tests etc) please go over them and try to solve reach me if you need help for that thank in advance!

[cyble-dev]

Hi @ilappe , While addressing the UP017 rule (Use datetime.UTC), I ran into an issue — datetime.UTC isn’t available in Python 3.10, which leads to this error: AttributeError: type object 'datetime.datetime' has no attribute 'UTC'

Since Cortex XSOAR currently runs on Python 3.10, I’ve kept timezone.utc instead of switching to datetime.UTC to maintain compatibility and avoid runtime errors during test execution.

Let me know if you'd prefer suppressing the rule instead or handling it differently.

Thanks!

[ilappe]

Hi @cyble-dev thanks for your effort! it's look like there is a lot of problems here

• some of them may be solved by running demisto-sdk pre-commit
• please add a description for the new mirror commands defined in the yml
• the python version of this integration are 3.12.8 so the datetime.UTC should be supported
• it's look like you try to supporting both mirror direction, but the dbotMirrorDirection defined in Packs/CybleEventsV2/Classifiers/classifier-CybleEventsv2-Incoming-Mapper.json is still Out
• consider to add the mirror_direction param, see description for that
• please bump the pack version

after solving those, i will continue to review the updated code if you need any help, feel free to reach me here or in Slack Thanks a lot!

[cyble-dev]

Hi @cyble-dev thanks for your effort! it's look like there is a lot of problems here

• some of them may be solved by running demisto-sdk pre-commit
• please add a description for the new mirror commands defined in the yml
• the python version of this integration are 3.12.8 so the datetime.UTC should be supported
• it's look like you try to supporting both mirror direction, but the dbotMirrorDirection defined in Packs/CybleEventsV2/Classifiers/classifier-CybleEventsv2-Incoming-Mapper.json is still Out
• consider to add the mirror_direction param, see description for that
• please bump the pack version

after solving those, i will continue to review the updated code if you need any help, feel free to reach me here or in Slack Thanks a lot!

Upon using datetime.UTC, pytest gives the following error- "AttributeError: type object 'datetime.datetime' has no attribute 'UTC' " ,

Can you please suggest a workaround?

[cyble-dev]

Hi @ilappe, could you please share a link or send an invite so I can reach out to you on Slack?

[ilappe]

Hi @ilappe, could you please share a link or send an invite so I can reach out to you on Slack?

Hi are you in the DFIR Slack workspace?, if so this my link if not, please get me your full name in Slack and i will asking for adding you thanks!

[cyble-dev]

Hi @ilappe, could you please share a link or send an invite so I can reach out to you on Slack?

Hi are you in the DFIR Slack workspace?, if so this my link if not, please get me your full name in Slack and i will asking for adding you thanks!

Hi @ilappe No, I am not in the DFIR workspace. Please add me Name: Tushar Parwani email: [email protected]

[ilappe]

Thanks @cyble-dev I asked the administrator to add you.

[cyble-dev]

Thanks @cyble-dev I asked the administrator to add you.

Hi @ilappe , Just following up on your message regarding access to the DFIR workspace. Please let me know once I’ve been added.

[ilappe]

Thanks @cyble-dev I asked the administrator to add you.

Hi @ilappe , Just following up on your message regarding access to the DFIR workspace. Please let me know once I’ve been added.

Hi the administrator updated me that he had sent please check if you got some invite.

[github-actions[bot]]

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.