content icon indicating copy to clipboard operation
content copied to clipboard
verified publisher icon demisto

Enhancement cybel angel

Open almog2296 opened this issue 8 months ago • 2 comments

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • [x] In Progress
  • [ ] Ready
  • [ ] In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Adding support for 2 more events. only for XSIAM

Must have

  • [ ] Tests
  • [ ] Documentation

almog2296 avatar May 14 '25 12:05 almog2296

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CybelAngel/Integrations/CybelAngelEventCollector
   CybelAngelEventCollector.py2651594%60–62, 148–149, 399–400, 414–415, 428, 440, 454, 730, 767, 892
TOTAL2651594% 

Tests Skipped Failures Errors Time
33 0 :zzz: 0 :x: 0 :fire: 3.854s :stopwatch:

github-actions[bot] avatar May 14 '25 12:05 github-actions[bot]

@richardbluestone please have a look in this PR, thanks :)

Shellyber avatar Jun 11 '25 09:06 Shellyber

Doc review done

richardbluestone avatar Jun 11 '25 10:06 richardbluestone

"Parameters have been removed from the integration, the removed parameters are: 'first_fetch'. Validate summary". The parameters isn't relevant anymore.

almog2296 avatar Jun 29 '25 14:06 almog2296

Validate summary The following errors were thrown as a part of this pr: BC112. The following errors cannot be ignored: BC112. The following errors don't run as part of the nightly flow and therefore can be force merged: BC112.

Verdict: PR can be force merged from validate perspective? ✅

content-bot avatar Jul 01 '25 06:07 content-bot