Add content cache to integration
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
- [x] In Progress
- [ ] Ready
- [ ] In Hold - (Reason for hold)
Related Issues
fixes: Old PR
Description
This PR is linked to our previous PR that involved a button. We are now utilizing the cache integration feature to retrieve events. As a reminder, the issue was with our polling function, which did not work in either the fetch_incident function or the mirroring function. Consequently, we have implemented a new solution to obtain events from our platform.
Must have
- [ ] Tests
- [ ] Documentation
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
11 out of 23 committers have signed the CLA.
:white_check_mark: sdaniel6
:white_check_mark: Ni-Knight
:white_check_mark: eyalpalo
:white_check_mark: ilappe
:white_check_mark: TOUFIKIzakarya
:white_check_mark: YuvHayun
:white_check_mark: aaron1535
:white_check_mark: MosheEichler
:white_check_mark: ilaredo
:white_check_mark: thefrieddan1
:white_check_mark: merit-maita
:x: hyaffe839
:x: moishce
:x: kobymeir
:x: efelmandar
:x: rshunim
:x: noydavidi
:x: idovandijk
:x: mayyagoldman
:x: lironcohen272
:x: karinafishman
:x: BarGali
:x: nbensalm-palo
You have signed the CLA already but the status is still pending? Let us recheck it.
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @mmhw will know the proposed changes are ready to be reviewed. For your convenience, here is a link to the contributions SLAs document.
Hi @TOUFIKIzakarya, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.
@TOUFIKIzakarya please update version and readme
Hello @edik24,
I added the version, for the readme i don't think that we have to update it. There was no argument added to the 3 functions. I will add some more tests for the CI coverage.
Hello,
Thanks for the review guys, i'm working on that but also i'm working on a small edge case when job uuid expires. So i will push that as soon as possible.
Hello again,
Thanks for reviews guys, i have an urgent PR to be merged ( this one ) because we are missing a lot of events with that. can you please help do that. After this i can bump the version for this one and continue working on it.
cc @mmhw @karinafishman @edik24
Approved from my end
Hello @mmhw,
Sorry for that, but I will close this PR. I created another one with a clean git commit history.
Hi @TOUFIKIzakarya, No problem, I'll close it.