node-mi-flora icon indicating copy to clipboard operation
node-mi-flora copied to clipboard

Pass config object

Open webnator opened this issue 7 years ago • 2 comments

I've recently began using your library and I think it's really great. For some reason, my device has a different name than the one that defaults in the library, so I thought it'd be cool if I was able to change via config params these default settings, so I made it. If you feel that these could be useful, go ahead and merge it in your project.

webnator avatar Sep 28 '17 19:09 webnator

Thanks for the pr @webnator. I'll go through it when I get my new flora to test it. Also I gotta need to create a test coverage for the package as well.

demirhanaydin avatar Oct 01 '17 20:10 demirhanaydin

Awesome! I didn't see the tests in the repo, but if you need help testing, let me know. I usually use jest, and it works really good. See you

webnator avatar Oct 01 '17 22:10 webnator