Buff System Overhaul

[webadict]

The Buff system has several issues that need addressing. Currently, Buffs exist as static changes in Attributes on Entities. This causes several issues with a variety of cards:

• Wee Spellstopper + Faceless Manipulator - Patched as a separate Attribute type to work similarly to Untargetable By Spells
• Auras + Faceless Manipulator - Minions can have higher health totals than they should when copied in a Health Aura (A 3/1 Loot Hoarder alongside a Stormwind Champion should become a 2/0 Loot Hoarder when copied.)
• Shadowcaster/Mistcaller - Cards in hand should be able to hold a buff stack similar to Minions, but current limitations cause issues with buffed minions when used with cards like:
  • Resurrect/N'Zoth/Anyfin Can Happen - Summons a copy of the minion from the source card. Copying the source card can fix Mistcaller, but this does not fix Shadowcaster, due to the nature of how the buffs are applied. Removing more and more Attributes back to their base fixes some issues, but not others.
  • Future cards: Adding deathrattles to minion cards in hand could be possible, but would cause issues with N'Zoth currently.

I know this is already on the plate, but I figured I'd bring up some additional issues that might appear with it.