Yves Orton
Yves Orton
I hacked late last night, and i see that the latest push has some broken artifacts. Shoulda packed it in earlier. Just a FYI I know about it and im...
@khwilliamson thanks for the feedback, ill review in detail later. ALL: I messed up and fat finger pushed a broken version of the PR, ill fix it up later, possibly...
On Thu, 1 Sept 2022, 18:40 Bram, ***@***.***> wrote: > I think the first commits can be merged as-is, > > For the whitespace cleanup commit, skimming the files: >...
> After thinking about this some more, I don't think we should be adjusting white space in comments other than to wrap text and expand any tabs. @khwilliamson at first...
Ok, so only touch a block comment if it actually contains a line that is longer than desired? Anyway, for what its worth i put some effort into making it...
@khwilliamson I dropped this for a bit. Ill get it regenerated onto the latest version of blead ASAP.
Oh, hrm, that chain of reflow C comments at the end means something is wrong. I will check what it is.
IMO we should define an "opcode version" magic var, define, whatever, that people can test. If they look at our optree they should check the opcode-version, if they are not...
The examples zefram provided still segfault or assert in 5.37.4 and 5.34.1.