find-my-way icon indicating copy to clipboard operation
find-my-way copied to clipboard

Published 20 hours ago • verified publisher icon delvedor

weird pretty-print of routes

Open AVVS opened this issue 7 years ago • 8 comments

Please check the screenshots, looks like just a glitch with the names

screen shot 2018-06-28 at 12 28 40 pm screen shot 2018-06-28 at 12 28 33 pm

AVVS avatar Jun 28 '18 19:06 AVVS

Nice finding! Would you like to help out with a PR?

mcollina avatar Jun 28 '18 19:06 mcollina

I don't know about the time I can devote to it right now, though if nobody tackles it I can definitely give it a go

AVVS avatar Jun 28 '18 19:06 AVVS

Thanks for reporting this! If we want to fix this we might want to refactor that function to use node-archy which will simplify the code.

delvedor avatar Jun 28 '18 19:06 delvedor

@delvedor Hi. I'll work on this issue if you don't mind.

poppinlp avatar Sep 15 '18 03:09 poppinlp

awesome!

Il giorno sab 15 set 2018 alle 05:23 PoppinL [email protected] ha scritto:

@delvedor https://github.com/delvedor Hi. I'll work on this issue if you don't mind.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/delvedor/find-my-way/issues/82#issuecomment-421527031, or mute the thread https://github.com/notifications/unsubscribe-auth/AADL46iPXGP4wbPkxkzFWmoq7CjksC-qks5ubHKvgaJpZM4U782F .

mcollina avatar Sep 15 '18 18:09 mcollina

@poppinlp thanks! Actually, I don't know if we want to support this feature in the future. Before work on it, I would suggest waiting for https://github.com/delvedor/find-my-way/pull/89, which will change the internals a lot.

delvedor avatar Sep 17 '18 10:09 delvedor

OK. Got it. Actually i have almost finish that. Should i done it or wait for that refactor?

poppinlp avatar Sep 18 '18 03:09 poppinlp

You can open a pr, but #89 will change completely how find-my-way works internally, and eventually, we will remove the prettyPrint API.

delvedor avatar Sep 18 '18 08:09 delvedor