deluge icon indicating copy to clipboard operation
deluge copied to clipboard

[3541][GTK] Fix Add-torrent-dialog not respecting dirs

Open DjLegolas opened this issue 2 years ago • 2 comments

When adding a new torrent, there is a problem changing the path on Windows machines, due to the difference between the way the files are being read from the torrent and how we handle them in addtorrentdialog. This effects both changing and showing the files in the UI.

Now, all path seperator is being considered and converted to slash '/'.

Closes: https://dev.deluge-torrent.org/ticket/3541

DjLegolas avatar Aug 06 '22 20:08 DjLegolas

How can this only just been noticed on Windows? Switching back to using the fixed path separator should be carefully considered so I would like to know more about this especially why it no longer applies.

Especially since it reverts this original change: https://github.com/deluge-torrent/deluge/commit/14f894959fb59ef3634fe3d531563399288d6bcc

cas-- avatar Aug 06 '22 21:08 cas--

This is something that as changed in the TorrentInfo class inside the deluge.ui.common package in https://github.com/deluge-torrent/deluge/commit/3ec23ad96bfa205c8ae23b662c6da153efbfed3a. As you can see, all paths in it are being converted to posix path, but in the addtorrentdialog.py file we are trying to split the paths according to os.path.sep, which in Windows is \.

DjLegolas avatar Aug 06 '22 22:08 DjLegolas

How is this still happening 2 years later?

ER-95 avatar Apr 22 '24 15:04 ER-95

Because there hasn't been a new release where this commit is in.

On Mon, Apr 22, 2024 at 8:36 AM ER @.***> wrote:

How is this still happening 2 years later?

— Reply to this email directly, view it on GitHub https://github.com/deluge-torrent/deluge/pull/395#issuecomment-2069924878, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGX3EJEV3ND3WQJKMGFYWDY6UU7PAVCNFSM55ZILFJKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBWHE4TENBYG44A . You are receiving this because you commented.Message ID: @.***>

zhen-huan-hu avatar Apr 22 '24 23:04 zhen-huan-hu