deluge icon indicating copy to clipboard operation
deluge copied to clipboard

Support announcing to all trackers of the same tier.

Open Unit193 opened this issue 3 years ago • 5 comments

This fixes bug http://dev.deluge-torrent.org/ticket/1395

Unit193 avatar Dec 17 '21 06:12 Unit193

Looks good. Also, if you can, please add this to the WebUI (and console) as well.

DjLegolas avatar Dec 18 '21 00:12 DjLegolas

Ah yes, good plan. I haven't tested those of course, but I've been using this patch otherwise for quite some time.

Unit193 avatar Dec 18 '21 00:12 Unit193

Can I just clarify what implementation we trying to achieve here with regards tracker announcing since there are two options:

announce_to_all_trackers

all trackers in the same tier are announced to in parallel. If all trackers in tier 0 fails, all trackers in tier 1 are announced as well.

announce_to_all_tiers

one tracker from each tier is announced to. This is the uTorrent behavior.

I have updated the Trac ticket with relevance discussion points but my take on this is to use the latter announce_to_all_tiers as per uT.

cas-- avatar Jun 12 '22 17:06 cas--

I'd have gone for the former, it makes a lot more sense to me as you can configure exactly which trackers are fallback, and makes more logical sense to treat trackers set as the same priority in the list, well, the same.

It seems they're taking an entirely different definition to the tiers though, which if selecting this option would surprise me as a user as I'd have different expectations. Perhaps a mouseover if the latter is used?

Unit193 avatar Jun 12 '22 22:06 Unit193

@cas-- I'm not specifically attached to the one way of doing this, I do have a preference but in the end either way will allow me to do what I want (without locally patching.) If you have wording suggestions for mouseover text or whatnot, that'd be appreciated too (unless you want to just adapt it.)

Unit193 avatar Jul 20 '22 06:07 Unit193