astro-embed icon indicating copy to clipboard operation
astro-embed copied to clipboard

Support Starlight 0.32

Open oluwatobiss opened this issue 10 months ago • 2 comments

The plugin stops working after upgrading from Starlight v0.31.1 to v0.32.0. This is probably because Starlight now accesses the current route's data object via Astro.locals.starlightRoute rather than Astro.props, which was used in the previous version.

oluwatobiss avatar Feb 18 '25 11:02 oluwatobiss

Hmm, could you share a reproduction? This package is not specific to Starlight and doesn’t need to access the route data object.

delucis avatar Feb 18 '25 11:02 delucis

This is a very strange one—the conflict seems to be between Astro Embed 0.9.0 and Starlight Blog 0.17.2's CSS.

The plugin works without Starlight Blog:

Astro embed works without Starlight blog

However, only the Play text shows when Starlight Blog is installed.

Astro embed with Starlight blog shows only a play text

Here's the reproduction:

https://github.com/oluwatobiss/astro-embed-issue-185-reproduction

oluwatobiss avatar Feb 18 '25 13:02 oluwatobiss

Going to close this as hopefully fixed by #2905 — happy to see a new issue with a reproduction if folks are still running into this.

delucis avatar May 16 '25 09:05 delucis