deltachat-ios icon indicating copy to clipboard operation
deltachat-ios copied to clipboard

switch accounts if nececssary for direct share shortcuts

Open cyBerta opened this issue 1 year ago • 3 comments

part of #1703

not yet implemented: UI changes. We could add the account avatar to the navigation bar, e.g. left of the cancel button or left of the send button (maybe that get's more attention, before the user hits the send button). We can also add another row to the bottom showing the account name there (unfortunately but without an icon using the basic iOS share framework) and could give an option to switch accounts there. That might become especially useful in case the user didn't select a direct share shortcut, but the general delta chat share icon. Opinions welcome :)

cyBerta avatar Oct 05 '22 18:10 cyBerta

left of the cancel button

+1, for consistency with the main app where the account-self-avatar is also shown topmost left. but that can also go to another pr.

r10s avatar Oct 06 '22 13:10 r10s

added icon:

cyBerta avatar Oct 07 '22 15:10 cyBerta

I really like the idea of being able to switch accounts when sharing. Maybe it would look better if the avatar is placed in the middle between "Cancel" and "Send"? However, if it should be to the left, iMessage could perhaps be an example. The top left corner is blank in the iMessage share screen. The avatar could be displayed here. This design is probably more complex to implement. I created a mockup screenshot for both options.

Avatar in the middle:

Share screen derived from iMessage:

Raiden-GH avatar Oct 08 '22 12:10 Raiden-GH

@r10s Let's get that in. It fixes a bug in context of multi-account and gives additionally a hint from which account the message is going to be shared. Further improvements wrt. to UI can be done in a subsequent PR.

cyBerta avatar Nov 01 '22 10:11 cyBerta

We can proceed with another PR

cyBerta avatar Nov 01 '22 17:11 cyBerta