deltachat-ios
deltachat-ios copied to clipboard
deltachat
register for `dcaccount:` scheme
tested with system camera, tap on link from browser (webxdc.org qr code), new welcome view qr code reader and global QR-View qr code reader
closes https://github.com/deltachat/deltachat-ios/issues/1576
thanks for pushing this forward! I will have a more in depth look into it tomorrow.
I've discussed how to proceed with the dcaccount url scheme handling with @r10s and we thought it might be a good idea to fix some more issues when we're already at it:
- currently there are 2 different methods handling qr codes, in the WelcomeView for dcaccounts and in the AppCoordinator for all other qr codes. Instead we would like to have one central method reponsible for QR-code handling in the AppCoordinator
- as a result dcaccount qr codes can be read currently onlyfrom the WelcomeViewController but not from DC's general QR code reader. that should be improved, too.
Instead of having an extra handling here: https://github.com/deltachat/deltachat-ios/pull/1640/files#diff-fc4377fbb4c60bfc9a11f53fd448de91bbf34787141509ddb85242515fea9e23R178 we would just pass the url to self.appCoordinator.handleQRCode(urlString) just as it is done for openpgp4fpr.
That requires a little bit more of refactoring but it's worth the effort.
@cyBerta you go for it, right?
if we merge the two handleQrCode() functions, we should still make sure, that from the login screen is only DCACCOUNTS allowed (maybe more in the future).
I agree with the plan, don't have time to do it myself soon so I would also be glad if @cyBerta takes it from here.