deltachat-desktop icon indicating copy to clipboard operation
deltachat-desktop copied to clipboard

🚧 feat: Ephemeral peer channels

Open Septias opened this issue 1 year ago • 2 comments

Part of https://github.com/deltachat/deltachat-core-rust/pull/5346

Septias avatar Apr 01 '24 12:04 Septias

On Tue, Apr 02, 2024 at 09:13 -0700, Simon Laux wrote:

@Simon-Laux commented on this pull request.

@@ -62,6 +68,10 @@ onStatusUpdate() return promise },

  • setEphemeralUpdateListener: (cb) => {
  •  ipcRenderer.invoke('webxdc.sendGossipAdvertisement')
    

like "more info"(linking to inApp Help), "Deny", "Allow" and a checkbox "remember choice for this webxdc app"

would mean you need to track per-app what is allowed, and then allow folks to change it later -- quite some UI and user-communication effort.

whatsapp and signal enable P2P by default for voice-calls and have a single global option "always relay calls"/"Protect IP address in calls" which defaults to "off" for both, and is in advanced options. Probably makes sense as a global option because either you care or you don't.

ASFAIK iroh/integration is not able to do User1->relay1->relay2->User2 yet so if i am not mistaken we can not right now offer it like this. I tentatively suggest to only introduce a global option to enable/disable ephemeral channels and have translated strings for what it means, and probably default to off at first.

hpk42 avatar Apr 02 '24 20:04 hpk42

I also think that a single configuration option should suffice. Maybe we can talk to the iroh people about our need for IP address protection.

Septias avatar Apr 03 '24 10:04 Septias

So we decided to squash merge this when the time is ready.

  • This depends on a core with this pr merged https://github.com/deltachat/deltachat-core-rust/pull/5607, so as of the time of writing this it is not merged yet.

Simon-Laux avatar May 31 '24 18:05 Simon-Laux

Core PR has been merged

Septias avatar Jun 04 '24 13:06 Septias

It was supposed to be squashed O_O

link2xt avatar Jun 04 '24 14:06 link2xt

sorry was in a hurry and annoyed that I needed to fix to the new config key, so I forgot that

Simon-Laux avatar Jun 04 '24 15:06 Simon-Laux