deltachat-desktop icon indicating copy to clipboard operation
deltachat-desktop copied to clipboard

"Open" instead of "Save" in directory selector

Open Raiden-GH opened this issue 1 year ago • 10 comments

When exporting a key, the directory selector displays "Open" instead of "Save". Version: 1.43.1 macOS 14.3.1

Raiden-GH avatar Feb 28 '24 19:02 Raiden-GH

Not sure what is meant exactly, but at least i can say that there are "Cancel" and "Open" buttons in the "Export Secret Keys" window. Probably there should be "Save"

iequidoo avatar Feb 28 '24 23:02 iequidoo

Yes, that is exactly what I meant.

Raiden-GH avatar Feb 29 '24 00:02 Raiden-GH

Bildschirmfoto 2024-03-01 um 17 19 00

Currently it exports 2 files so "open directory" is correct. we can replace the label of the button, though not sure if that is the perfect solution, but let's do that.

Simon-Laux avatar Mar 01 '24 16:03 Simon-Laux

Currently it exports 2 files so "open directory" is correct

But the directory is already open. The two files also have to be saved?

Raiden-GH avatar Mar 01 '24 16:03 Raiden-GH

the dialogs purpose is to select a directory

Simon-Laux avatar Mar 01 '24 16:03 Simon-Laux

Hmm, I thought that the button gives the command to save the files in this directory and not to open it, because it is already open? The dialog for backup is the same.

Raiden-GH avatar Mar 01 '24 17:03 Raiden-GH

the dialogs purpose is to select a directory

Then probably it's better to leave it "Open". Otherwise a user could think that "Save" means "save in the current dir". But maybe a better option would be "Select".

iequidoo avatar Mar 01 '24 17:03 iequidoo

But maybe a better option would be "Select".

Yes, I think "Select" or "Select Folder" would also be suitable. I understood "Save" in such a way that the files are saved in the selected directory. The directory is already open at this point, so in my opinion "Open" wouldn't make any sense.

Raiden-GH avatar Mar 01 '24 18:03 Raiden-GH

I was about to comment the same thing as @raiden-social last comment. It should be "Select directory/folder" or something of this line IMO.

farooqkz avatar Mar 01 '24 19:03 farooqkz

It should be "Select directory/folder" or something of this line IMO.

Perhaps in this case the "Save" button in the backup directory selection window should also be changed to "Select Folder"?

Raiden-GH avatar Mar 01 '24 21:03 Raiden-GH