deltachat-core icon indicating copy to clipboard operation
deltachat-core copied to clipboard

Published 20 hours ago • verified publisher icon deltachat

allow importing a concrete key

Open r10s opened this issue 6 years ago • 3 comments

currently, dc_imex(DC_IMEX_IMPORT_SELF_KEYS) requests a directory as the first parameter; the directory is scanned for keys that are imported then.

while this is fine for mobile systems with limited file management functions, users on desktop may expect the option to select an explicit file, cmp. https://github.com/deltachat/deltachat-desktop/issues/251

i suggest to adapt dc_imex(DC_IMEX_IMPORT_SELF_KEYS) so that the first parameter can be a file or a dircetory. this is also on pair with dc_imex(DC_IMEX_IMPORT_BACKUP) which also expects a file.

for exporting keys i would not change the behavior currently as typically several keys will be imported, each to a separate file and i would like to avoid having a key management dialog in dc.

r10s avatar Dec 22 '18 13:12 r10s

On Sat, Dec 22, 2018 at 05:28 -0800, björn petersen wrote:

currently, dc_imex(DC_IMEX_IMPORT_SELF_KEYS) requests a directory as the first parameter; the directory is scanned for keys that are imported then.

while this is fine for mobile systems with limited file management functions, users on desktop may expect the option to select an explicit file, cmp. https://github.com/deltachat/deltachat-desktop/issues/251

i suggest to adapt dc_imex(DC_IMEX_IMPORT_SELF_KEYS) so that the first parameter can be a file or a dircetory. this is also on pair with ``dc_imex(DC_IMEX_IMPORT_BACKUP)` which also expects a file.

I'd tend to rather phase out passing directories for $reasons but find accepting both fine for now ;)

hpk42 avatar Dec 22 '18 13:12 hpk42

I'd tend to rather phase out passing directories for $reasons

this would result in some more effort on android, where there is no fileselector afaik. and i do not like to put much effort in this currently. it's mainly needed for experts and whatever is done with the keys in other apps is potentially more complicated than the export/import in dc imho.

r10s avatar Dec 22 '18 14:12 r10s

but i think we should go for two different import types as DC_IMEX_IMPORT_SELF_KEYS_DIRECTORY and DC_IMEX_IMPORT_SELF_KEY_FILE - so that things cannot be mixed accidentally ...

r10s avatar Dec 22 '18 16:12 r10s