deltachat-core-rust icon indicating copy to clipboard operation
deltachat-core-rust copied to clipboard

Published 20 hours ago • verified publisher icon deltachat

fix: realtime late join

Open Septias opened this issue 6 months ago • 1 comments

This PR adds a test to reproduce a bug raised by @adbenitez that peer channels break when the resend feature is used.

Septias avatar May 21 '25 08:05 Septias

This is still WIP? This only adds tests.

WofWca avatar May 22 '25 20:05 WofWca

Found out that somehow the wrong iroh topic is transmitted to fiona and that is why she fails to join. In every send invocation a new topic is generated, and we use resend...

Septias avatar Jul 07 '25 11:07 Septias

@link2xt I made some unrelated changes, which are easy to track in the individual commits, but they pollute the final PR. Would you prefer to split this into a refactor and bug-fix PR?

Septias avatar Jul 08 '25 09:07 Septias

I made some unrelated changes, which are easy to track in the individual commits, but they pollute the final PR. Would you prefer to split this into a refactor and bug-fix PR?

If it's just these documentation updates then no need to split this.

link2xt avatar Jul 09 '25 20:07 link2xt

It seems like the test is a bit flaky (for me it ran 7/8 times), but I do not know a fix of the top of my head yet.. Maybe we can just check how often it actually happens and fix it if neccessary in a follow up PR

Septias avatar Jul 10 '25 10:07 Septias

The newly-added test seems to be flaky, I created an issue: https://github.com/chatmail/core/issues/7035

Hocuri avatar Jul 23 '25 13:07 Hocuri