deltachat
Not fully downloaded message edit is lost
If you get a large message that is not fully downloaded, and then an edit message, you get the text replaced with an edit. Then when you download the full message, text gets replaced by the original instead of staying edited.
If the text of the message is edited (we know it because we show "Edited"), fully downloading the message should not replace the text with original.
EDIT: Reordered edits must be handled correctly also: https://github.com/chatmail/core/issues/6806#issuecomment-3005608761
I've created a test that attempts to reproduce this bug. Test fails, which is expected.
When thinking about fixing this issue, this question comes up: what if two edit messages come in the wrong order? is there some mechanism to check the validity of edits sequence? An edit-chain? 😅
edit requests come with timestamp, that is good enough for ordering and to ensure only the last edit is shown.
we use that timestamp at lots of similar changes, eg group name changes
But when looking at handle_edit_delete(), i don't see that timestamp_sent of the edit participates in any logic. Probably this is another bug that should be fixed.
... It'd good to update timestamp_sent of the message from the edit and only apply edits with greater-or-equal timestamps.
If no one else is working on this, I want dive deeper into this issue and try to fix it.
If no one else is working on this, I want dive deeper into this issue and try to fix it.
I think we can use github's "Assignees" for this. Even if someone forgot to self-assign the task, they will be notified if they are subscribed to the repo.
I think we can use github's "Assignees" for this. Even if someone forgot to self-assign the task, they will be notified if they are subscribed to the repo.
Sure, but I guess I do not have permission to assign 😄
assigning rarely is done anywhere here in the repo, and it's not neccessary. Just do a PR referencing this issue here, and try to bring it into reviewable state :)
