deltachat-core-rust icon indicating copy to clipboard operation
deltachat-core-rust copied to clipboard

feat: jsonrpc: add `late_file_message_mediasize`

Open Simon-Laux opened this issue 10 months ago • 2 comments

Simon-Laux avatar Jan 12 '25 03:01 Simon-Laux

I don't understand the purpose of this PR. If the core is buggy and provides wrong dimensions, UI has to check and correct it, we can as well just drop the API to read these values and move the logic entirely in the UI instead of the UI telling the core what it should tell the UI.

link2xt avatar Feb 22 '25 08:02 link2xt

the idea of the api was to speed up things on subsequent loads on android, eg UI can show placeholder in correct aspect ratio, leading to less flickering and jumping, esp if there are lots of images/videos

but that was 7 years ago, if desktop could live without the api up to now, there might be no need :)

for android, we can check that at some point, if it is still needed, i would not remove the api just now

r10s avatar Feb 22 '25 22:02 r10s

closing for now, desktop found a different solution, we can still re-open or redo should there be a need in the future.

Simon-Laux avatar Oct 02 '25 15:10 Simon-Laux