deltachat-core-rust icon indicating copy to clipboard operation
deltachat-core-rust copied to clipboard

Published 20 hours ago • verified publisher icon deltachat

build: update tokio to 1.40 and Android NDK to r27

Open link2xt opened this issue 1 year ago • 4 comments

Delta Chat for Android does not support Android 4 anymore, so there is no reason to keep using unsupported NDK.

r27 is the latest LTS version of Android NDK.

Tested:

  • nix build .#deltachat-rpc-server-arm64-v8a-android
  • nix build .#deltachat-rpc-server-armv6l-linux

nix build .#deltachat-rpc-server-x86_64-android and nix build .#deltachat-rpc-server-x86-android still fail, but we do not build it in CI.

link2xt avatar Aug 15 '24 02:08 link2xt

Corresponding Android PR: https://github.com/deltachat/deltachat-android/pull/3229

link2xt avatar Sep 04 '24 00:09 link2xt

nix build .#deltachat-rpc-server-x86_64-android and nix build .#deltachat-rpc-server-x86-android still fail, but we do not build it in CI.

what is the meaning/implications of this?

adbenitez avatar Sep 04 '24 11:09 adbenitez

this should not be merged until android PR is merged

adbenitez avatar Sep 04 '24 13:09 adbenitez

Delta Chat for Android does not support Android 5 anymore,

Android 5 already? https://github.com/deltachat/deltachat-android/pull/3229 says that the support of Android 4 is dropped

iequidoo avatar Sep 04 '24 16:09 iequidoo

With this NDK nix flake update android does not break the build like it happens with r24: https://github.com/deltachat/deltachat-core-rust/issues/6094

link2xt avatar Oct 23 '24 04:10 link2xt

Going to merge this once CI passes as iroh now (accidentally?) requires tokio 1.41: https://github.com/n0-computer/iroh/issues/2887

link2xt avatar Nov 04 '24 19:11 link2xt