deltachat-core-rust icon indicating copy to clipboard operation
deltachat-core-rust copied to clipboard

feat: Limit the size of aggregated WebXDC update to 100 KiB (#4825)

Open iequidoo opened this issue 1 year ago • 2 comments

See commit messages. Close #4825

iequidoo avatar Apr 23 '24 08:04 iequidoo

Also don't send any updates together with the WebXDC instance to not complicate the code, the only downside is sending one message more when resending or forwarding WebXDC instances.

What happens in case of message draft where sender wants to set up everything (e.g. a poll) before sending the message out? I think this should always be a single message so we are sure that second message is not lost.

In case of forwarding we don't send updates anyway.

link2xt avatar Apr 25 '24 10:04 link2xt

What happens in case of message draft where sender wants to set up everything (e.g. a poll) before sending the message out? I think this should always be a single message so we are sure that second message is not lost.

Makes sense, i'll change this back. But in case of resending it's easier not to send any updates together with the instance, but in separate messages of limited size.

In case of forwarding we don't send updates anyway.

True, and this is not changed, will fix the commit message.

EDIT: Done

iequidoo avatar Apr 26 '24 00:04 iequidoo