deltachat-core-rust icon indicating copy to clipboard operation
deltachat-core-rust copied to clipboard

Remove StockMessage.action_by_contact()

Open link2xt opened this issue 2 years ago • 3 comments

Use separate strings for "... by me" and "... by contact" to make them easier to translate.

Fixes #3429

link2xt avatar Jul 24 '22 21:07 link2xt

maybe even remove the "by me" variant, so also say on the senders device "action by NAME".

we talked about that in some chat, cc @adbenitez - advantages are fewer strings, less code and less confusion, eg. when using multiple accounts "by me" is not always clear. also, things look the same on sending and receiving devices (sender seens what the message reads on reveiver's side) and also fewer possible bugs in translations :)

r10s avatar Jul 24 '22 22:07 r10s

I changed strings "... done by me" to "You did ...". Other messengers say "you" in this case too.

Chat looking the same on all devices may be a good idea, but then we better remove "Me" string too and display username near the message. Message bubbles will still be placed left/right depending on whether the message is sent by us.

link2xt avatar Jul 24 '22 22:07 link2xt

the "you did ..." is nice, indeed. i am fine with that as well :)

r10s avatar Jul 24 '22 23:07 r10s

This is ready for review.

link2xt avatar Sep 05 '22 15:09 link2xt

This is ready for review.

great! i have this on my todo-list :) i will also create a corresponding android-pr and push the new strings to transifex then.

r10s avatar Sep 05 '22 16:09 r10s

@r10s I updated PR according to your review and regenerated node constants.

link2xt avatar Sep 10 '22 19:09 link2xt

great! i will create a corresponding android pr soon and re-check/merge this one then. thanks a lot for pushing this forward!

r10s avatar Sep 10 '22 21:09 r10s

resolved the CHANGELOG merge conflict and rebased.

r10s avatar Sep 11 '22 10:09 r10s

@r10s Fixed

link2xt avatar Sep 11 '22 16:09 link2xt