deltachat-core-rust
deltachat-core-rust copied to clipboard
deltachat
WIP: build preview of a core PR with dc-desktop:master
Just a small draft to build a desktop client from every core PR. This way developers can play around with the changes they just made easily.
question is how useful this will be because the nodebindings are in their own repo and not part of the core repo.
question is how useful this will be because the nodebindings are in their own repo and not part of the core repo.
Well, most core changes don't require changes in the node bindings, right? For those it would still be useful to have test candidates. Of course, if you need to change deltachat-node, too you need to build it manually. I can't estimate for how many % of PRs this is useful tbh, I just thought it because there are much less commits in deltachat-node than in deltachat-core-rust.
there will always be api changes and as soon as one of them is on master the nodebindings need to be updated too unless its just an additional api. so maybe it is time to think about moving the node-bindings into this repo, too.
node bindings are integrated into core repo.
It's easier for me to clone deltachat-desktop repo, point deltachat core dependency to deltachat-core-rust worktree and build it once, then to test a change in the core I run npm run build in the deltachat-core-rust repository and npm run dev in desktop, and it runs with the new core. Waiting for CI to build a package and then download it is much less convenient.
This needs to be updated for node integration if it's still useful for some workflow.
