deltachat-android icon indicating copy to clipboard operation
deltachat-android copied to clipboard

auto-generated RPC bindings

Open adbenitez opened this issue 1 year ago • 10 comments

  • [x] add new auto-generated chat.delta package with RPC bindings
  • [x] remove old manually generated rpc and util package
  • [x] use the new auto-generated Rpc API
  • [x] remove gson library from dependencies

adbenitez avatar May 24 '24 17:05 adbenitez

To test the changes in this pull request, install this apk: 📦 app-preview.apk

github-actions[bot] avatar May 24 '24 18:05 github-actions[bot]

To test the changes in this pull request, install this apk: 📦 app-preview.apk

github-actions[bot] avatar May 24 '24 19:05 github-actions[bot]

thanks for making this possible! this will make things much easier in the future!

however, for the ongoing release, this is a too large and massive change for 1.46.0 to 1.46.1+ - even if most things are auto-generated, i do not want to risk getting issues by that or dive into this topic completely, which is needed for review.

therefore, for the two missing jsonrpc for the peer-to-peer, we should add them by hand as before, i think, they do not even have parameters, so that should be easy.

when 1.46 is finally in all stores and things are settled so far we can finally go for this PR

r10s avatar May 26 '24 16:05 r10s

Where is the generator itself? And the docs regarding regenerating when core is updated are needed.

link2xt avatar May 27 '24 15:05 link2xt

Where is the generator itself?

it is closed source with a paid license subscription

adbenitez avatar May 27 '24 15:05 adbenitez

Where is the generator itself?

published it here: https://github.com/deltachat/dcrpcgen

adbenitez avatar May 27 '24 22:05 adbenitez

To test the changes in this pull request, install this apk: 📦 app-preview.apk

github-actions[bot] avatar May 27 '24 22:05 github-actions[bot]

I rebased the branch on main but now for some reason some changes from main appear as new changes :(

adbenitez avatar Jun 02 '24 12:06 adbenitez

To test the changes in this pull request, install this apk: 📦 app-preview.apk

github-actions[bot] avatar Jun 02 '24 12:06 github-actions[bot]

I rebased the branch on main but now for some reason some changes from main appear as new changes :(

You probably need to git rebase -i origin/main and drop everything that is not related to this PR.

link2xt avatar Jun 17 '24 17:06 link2xt

this needs more work/fixes it was not working as expected, with all changes in the code structure in the meanwhile, it is better to re-do/revive later

adbenitez avatar Aug 22 '24 14:08 adbenitez