deltachat-android
deltachat-android copied to clipboard
auto-generated RPC bindings
- [x] add new auto-generated
chat.deltapackage with RPC bindings - [x] remove old manually generated rpc and util package
- [x] use the new auto-generated Rpc API
- [x] remove gson library from dependencies
To test the changes in this pull request, install this apk: 📦 app-preview.apk
To test the changes in this pull request, install this apk: 📦 app-preview.apk
thanks for making this possible! this will make things much easier in the future!
however, for the ongoing release, this is a too large and massive change for 1.46.0 to 1.46.1+ - even if most things are auto-generated, i do not want to risk getting issues by that or dive into this topic completely, which is needed for review.
therefore, for the two missing jsonrpc for the peer-to-peer, we should add them by hand as before, i think, they do not even have parameters, so that should be easy.
when 1.46 is finally in all stores and things are settled so far we can finally go for this PR
Where is the generator itself? And the docs regarding regenerating when core is updated are needed.
Where is the generator itself?
it is closed source with a paid license subscription
Where is the generator itself?
published it here: https://github.com/deltachat/dcrpcgen
To test the changes in this pull request, install this apk: 📦 app-preview.apk
I rebased the branch on main but now for some reason some changes from main appear as new changes :(
To test the changes in this pull request, install this apk: 📦 app-preview.apk
I rebased the branch on main but now for some reason some changes from main appear as new changes :(
You probably need to git rebase -i origin/main and drop everything that is not related to this PR.
this needs more work/fixes it was not working as expected, with all changes in the code structure in the meanwhile, it is better to re-do/revive later