deltachat-android icon indicating copy to clipboard operation
deltachat-android copied to clipboard

move pref_system_emoji pref to advanced and enable it by default

Open adbenitez opened this issue 2 years ago • 8 comments

close #2980

adbenitez avatar Mar 28 '24 12:03 adbenitez

To test the changes in this pull request, install this apk: 📦 app-preview.apk

github-actions[bot] avatar Mar 28 '24 13:03 github-actions[bot]

hm, better go on pair with "in-app camera" and name the option "Use In-App Emoji" as well (inverted then), see https://github.com/deltachat/deltachat-android/issues/2980 - i would also define new strings for that, reusing with changed meanings will add some noise to translators.

so, pref_use_builtin_emoji and pref_use_builtin_emoji_explain, comparable to #2674

reason is also that we could tune further down by moving to "experimental" at some point (which needs to be off by default)

r10s avatar Mar 28 '24 17:03 r10s

(notice this PR changes the default to prefer system emoji for all DC users not only new ones, I was not sure how to detect this, but also I think it should be fine to change for all, they can always enable them again in the settings)

adbenitez avatar Mar 29 '24 06:03 adbenitez

yeah, wording looks lice now. thanks!

(notice this PR changes the default to prefer system emoji for all DC users not only new ones, I was not sure how to detect this

i would not try to detect it, but just continue using the old flag.

this would require little more code on handling in the settings, as we cannot leave that completely to .xml, but there are lots of other settings where we did that as well, should be easy

but also I think it should be fine to change for all, they can always enable them again in the settings)

while it is true that ppl can switch, we will need to deal with questions and discussions then. we have seen that several times, it seems better to move slowly here

r10s avatar Mar 29 '24 07:03 r10s

sorry for closing and adding noise /me cannot type on the phone today ...

r10s avatar Mar 29 '24 07:03 r10s

To test the changes in this pull request, install this apk: 📦 app-preview.apk

github-actions[bot] avatar Mar 29 '24 07:03 github-actions[bot]

To test the changes in this pull request, install this apk: 📦 app-preview.apk

github-actions[bot] avatar Mar 29 '24 07:03 github-actions[bot]

i would not try to detect it, but just continue using the old flag.

since old flag was for "use system emoji" and it was disabled by default, there is no old key value saved, so you can't know if the key is not set because it is a new user or because it is an old user that never changed the setting and hence was using built-in emoji :thinking:

adbenitez avatar Mar 29 '24 16:03 adbenitez

closing this PR, see https://github.com/deltachat/deltachat-android/issues/2980#issuecomment-2252706584 for the reasoning

adbenitez avatar Jul 26 '24 12:07 adbenitez