deltachat-android icon indicating copy to clipboard operation
deltachat-android copied to clipboard

Remove compile time dependency on GMS

Open link2xt opened this issue 1 year ago • 3 comments

Follow-up to #2349, runtime dependency and non-free components are removed, but GMS is still downloaded during the build.

See https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11527#note_1053804549

A quick solution to get DeltaChat to F-Droid is to use a patched version of mapbox-events-android, like here: https://github.com/johan12345/EVMap/commit/ed80d7b968826701d59b6590dfba7cf5a9611d74 Patched version is at https://github.com/johan12345/mapbox-events-android

Proper solution is to upstream fixes to MapLibre and introduce a free build flavour, suggested at https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11527#note_1053885392

link2xt avatar Aug 08 '22 10:08 link2xt

cc @adbenitez @Hocuri @missytake

I suggest that we

  1. Fork version with a fix https://github.com/johan12345/mapbox-events-android into deltachat org.
  2. Use forked version similarly to https://github.com/johan12345/EVMap/commit/ed80d7b968826701d59b6590dfba7cf5a9611d74 (via https://www.jitpack.io ?)
  3. Check that GMS is no longer referenced and downloaded at all.
  4. Release a new version and get it into F-Droid.

Assign the issue to self if you are going to do it.

Then keep this issue until the fix is upstreamed to MapLibre so we don't have to maintain a fork.

link2xt avatar Aug 08 '22 12:08 link2xt

There is a https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11532 that already works for me.

link2xt avatar Aug 09 '22 22:08 link2xt

Upstream report: https://github.com/maplibre/maplibre-gl-native/issues/379

link2xt avatar Aug 09 '22 22:08 link2xt

maplibre 10 is out for a while now, plans to update?

licaon-kter avatar Apr 11 '23 21:04 licaon-kter

maplibre 10 is out for a while now, plans to update?

I have tried to make an update at #2542, but MapLibre 10 breaks Android 4 support. Filed an upstream bugreport at https://github.com/maplibre/maplibre-gl-native/issues/1010

link2xt avatar Apr 12 '23 09:04 link2xt

since MapLibre 10 breaks support for Android 4 and it seems they can't bring it back lower than API level 18 anyway because their needs, so this issue can be closed also because meanwhile the issue is solved by fdroid somehow, any advancements in this area will be with the complete removal of MapLibre, not upgrading it, the path to follow will probably be similar to what DC iOS is planning: https://github.com/deltachat/deltachat-ios/pull/1912

adbenitez avatar Sep 25 '23 19:09 adbenitez