deltachat-android icon indicating copy to clipboard operation
deltachat-android copied to clipboard

The profile picture is rotated 90° counterclockwise

Open Gh0stz0x opened this issue 4 years ago • 13 comments

  • Operating System (Linux/Mac/Windows/iOS/Android): Android 10 - Lineage Os 17.1
  • Delta Chat Version: 1.14.5 - nightly
  • Expected behavior: When I select an image or take a photograph, I want it to stay where I took it.
  • Actual behavior: When I select an image, it rotates 90° counterclockwise
  • Steps to reproduce the problem: Go to settings, select the profile, change image by selecting it from the gallery or taking a photograph in portrait mode. The photograph will be rotated 90 ° counterclockwise. This bug was detected on Samsung and Xiaomi smartphones.
  • Screenshots: IMG_20210312_231019
  • Logs:

Gh0stz0x avatar Mar 12 '21 22:03 Gh0stz0x

Strange. I can't reproduce this on my Fairphone 3 w/ Android 10. And this happens both when you directly take a photo and when you select one from the gallery? Does it happen everytime or just sometimes? Did it only happen on LineageOS devices so far? Does it also happen if the device is in landscape mode?

Hocuri avatar Mar 13 '21 11:03 Hocuri

there is a related fix at https://github.com/deltachat/deltachat-core-rust/pull/2063, however, the fix is not release, but it is in the nigtlies (please double-check, that core 1.51.0-alpha.0 is used).

please note, that existing avatars are not rotated correctly after update, you can check that only with new avatars.

however, of course, may also be another issue :)

r10s avatar Mar 13 '21 11:03 r10s

@Hocuri It occurs either by taking a new photograph or by selecting a photograph from the gallery. @r10s The user who reported it to me told me that he uses the nightly. I try to check on a Samsung that I have to reproduce the problem and see which core it uses. However, the bug exists on both Android and Lineage.

ghost avatar Mar 13 '21 12:03 ghost

I looked on my Samsung log: it uses 1.51.0-alpha.0 core

ghost avatar Mar 13 '21 12:03 ghost

Does it also happen if the device is in landscape >mode?

@Hocuri I'll give it a try and I'll tell you

ghost avatar Mar 13 '21 12:03 ghost

@Hocuri If I do the landscape photography the photograph is "straight". Now I have asked the two users to test them too.

ghost avatar Mar 13 '21 12:03 ghost

there is a related fix at deltachat/deltachat-core-rust#2063, however, the fix is not release, but it is in the nigtlies (please double-check, that core 1.51.0-alpha.0 is used).

please note, that existing avatars are not rotated correctly after update, you can check that only with new avatars.

however, of course, may also be another issue :)

I just tried current master + #1837 and the problem still persists, it happens in my Samsung phone (stock android with android 10)

The issue is with the camera, selecting from gallery works fine for me, but taking pictures with the camera option, returns the image rotated, I can see it rotated in the "crop image" view before selecting

Screenshot_20210315-054127_DeltaLab

adbenitez avatar Mar 15 '21 09:03 adbenitez

The issue is with the camera

This made me think, maybe the bug is in the installed camera app (DC doesn't take the image but asks an installed camera app to do so)? Maybe you can try install another camera app (e.g. OpenCamera) and see if the issue persists?

Hocuri avatar Mar 15 '21 11:03 Hocuri

@Hocuri I tried with open camera and the problem is still present. @adbenitez the issue, for me, is present also selecting photos from gallery and I don't see the rotation in the "crop image" screen but only once done.

I am among those who initially reported the bug in version 1.15.0 beta (I've downloaded the nightly version on 10/03/2021). I have a xiaomi redmi note 7 with lineageos 17.1 without google services.

darhma avatar Mar 15 '21 13:03 darhma

The problem persists on my phone, a Sony with Android Androoid 8.0.0 and DC v. 1.14.5 When I choose a picture with "Pictures" it's shown alright, and the square crop is shown alright, but when I choose it it rotates.

havet avatar Apr 11 '21 12:04 havet

Unfortunately, this kind of problem might be a problem for the Delta Chat reputation: it appears simple to the user, who might infer that the software is of poor quality, containing lots of errors. The surface is important.

havet avatar Apr 11 '21 12:04 havet

Unfortunately, this kind of problem might be a problem for the Delta Chat reputation: it appears simple to the user, who might infer that the software is of poor quality, containing lots of errors. The surface is important.

yes, I was onboarding some friend and after installing the app the first steps were setting an avatar picture and all the images she tried were rotated, was really annoying, had to do a trick (editing the image in delta chat then exporting the image to finally set it as avatar)

adbenitez avatar Mar 24 '22 21:03 adbenitez

Is this one solved, and shall we close here?

gerryfrancis avatar Jul 06 '22 07:07 gerryfrancis

@gerryfrancis I try to ask if the bug still persists

ghost avatar Feb 05 '23 18:02 ghost

Looks like it's been fixed! If it comes back I'll reopen it! Thanks everyone! To you too Gerry, who are here to help!

ghost avatar Feb 05 '23 18:02 ghost

@Gh0stz0x Hey, many thanks for coming back and reporting here, glad to know that the issue is solved! :)

gerryfrancis avatar Feb 05 '23 23:02 gerryfrancis