deltachat
Adjust SSG pages & styles
Notes on the last commit:
- i was particularly surprised by the use of fractional pixels (e.g.
2.5px) which doesn't make sense (unless a page is scaled in browser) - relative sizes should be preferred over fixed (px), it's the "best practice"
- different margins on h1-h6 doesn't have any effect as they are merged with paragraphs' margins which always equal to 1em
As for https://github.com/chatmail/relay/pull/593/commits/2e8318647a515b94fb42231d9bb6f57ffcc0e071
Sorry, as I see it's the common design for all DeltaChat web pages, I'll return the button border and paddings, but please take a look at what i suggested, a button looks cleaner without a 1px-border (again, not 1.5px, fractional pixels make no sense) and with wider horizontal padding.
As for 2e83186
Sorry, as I see it's the common design for all DeltaChat web pages, I'll return the button border and paddings, but please take a look at what i suggested, a button looks cleaner without a 1px-border (again, not
1.5px, fractional pixels make no sense) and with wider horizontal padding.
maybe I'm holding it wrong, but I don't see much difference? Except this black line to the left which is a bit ugly:
Thanks for looking into this. Truth be told, I'm rather sceptical with this PR. What you call a "mess" (please watch your tone while judging the work of others, it can demotivate and is therefore bad practice) is part of what any operator is supposed to change about their instance
Yep, sorry, at that moment I was angry after editing web pages for my instance with different indentation (https://github.com/chatmail/relay/pull/593/commits/79c4e85eeaeefdedb4a5aa2064554b60b4d2863f) and even somehow non-ascii quotes in html (https://github.com/chatmail/relay/pull/593/commits/ade85c6880392690581c65e435309b2897ee0e0f)
I glanced at opened PRs and seen no changes correspoding static pages, so I supposed that it's OK to adjust whitespace as there would be no merge conflicts
Another codestyle thing that I've just reverted: single HTML tags. Sometimes they're written as <tag/>, sometimes as <tag />, sometimes <tag>. It doesn't change how a page look, yes, but it does change how much a web developer wants to work with this code