Byron Hambly

recreated this PR in #1594

Hey @binarybaron I do suspect it's the bdk change because of this error message: `invalid type: byte array, expected a script` Because the bump in rust-bitcoin that accompanied this changed...

> would you be okay with just reversing the upgrade from bdk 0.16 to 0.23 Not really, I'd much rather make a new release for 0.12. What changes do you...

I'll take a look at making a 0.11.1 release with everything except the bdk changes

I hear you, but what I’m saying is that we can make a release that excludes it - using the master branch can never guarantee non-breaking changes.

@binarybaron here's a branch with everything from that bdk upgrade removed https://github.com/comit-network/xmr-btc-swap/tree/0.11.x Want to give it a shot? I'm waiting on CI then I'll do a release from that branch...

> @binarybaron here's a branch with everything from that bdk upgrade removed https://github.com/comit-network/xmr-btc-swap/tree/0.11.x > > Want to give it a shot? I'm waiting on CI then I'll do a release...

No worries, happy to hear that. Let me take a quick look at this broken test and make a release for you.

Well, it's not an issue with 0.11.x but is likely to remain incompatible with master/the next major release 0.12

Actually want to keep this open so I can remember to try fix it