delta icon indicating copy to clipboard operation
delta copied to clipboard

Move SupportsAdmissionControl methods to DeltaSourceBase

Open jaceklaskowski opened this issue 3 years ago • 1 comments

DeltaSourceBase is a SupportsAdmissionControl but all the methods are in DeltaSource (looks like a leftover after a code refactor?) They should be moved off of DeltaSource to DeltaSourceBase.

/cc @scottsand-db

jaceklaskowski avatar Jul 30 '22 14:07 jaceklaskowski

@jaceklaskowski - this doesn't seem like a super critical refactor. The code wouldn't be that much simpler afterwards. We'd rather focus our review time on new features or bugs. If you feel passionately about this, feel free to make a PR though. But I think there's more interesting Delta stuff for you to work on :p See the good first issue and good medium issue labels.

scottsand-db avatar Aug 26 '22 19:08 scottsand-db