delta icon indicating copy to clipboard operation
delta copied to clipboard

[MINOR] Code Cleanup / Refactoring

Open jaceklaskowski opened this issue 3 years ago • 2 comments
trafficstars

Code Cleanup / Refactoring:

  • Use vals (not vars)
  • Fix scaladocs
  • Use constants
  • Check table availability with txn.deltaLog.tableExists (not txn.readVersion > -1)
  • Import reorg
  • Remove unused values

How was this patch tested?

  1. ./build/sbt clean package test:compile
  2. ./build/sbt clean '++ 2.13.5 ; package ; test:compile'

Waiting for the repo build to execute the entire testsuite.

Does this PR introduce any user-facing changes?

No

jaceklaskowski avatar Jul 28 '22 19:07 jaceklaskowski

@scottsand-db Please review 🙏

jaceklaskowski avatar Jul 28 '22 19:07 jaceklaskowski

Hey @scottsand-db, can I have your attention to this PR, please? Let me know if there's anything to make things easier and have it merged.

jaceklaskowski avatar Aug 04 '22 12:08 jaceklaskowski