delta icon indicating copy to clipboard operation
delta copied to clipboard

Published 20 hours ago • verified publisher icon delta-io

chore: Python codebase refactor

Open vincentkoc opened this issue 3 years ago • 5 comments

Description

Light refactor of python codebase with best practice, strings are escaped and some minor code tweaks.

How was this patch tested?

Locally tested using existing tests and codebase.

Does this PR introduce any user-facing changes?

No

vincentkoc avatar Jun 11 '22 06:06 vincentkoc

@allisonport-db @scottsand-db @tdas @vkorukanti mind reviewing this light refactoring PR?

vincentkoc avatar Jun 18 '22 05:06 vincentkoc

Hi @koconder - thanks for the ping. Yup I will be taking a look at it, just a little busy right now working on the next release of Delta. Will get to this soon! Thanks!

scottsand-db avatar Jun 21 '22 15:06 scottsand-db

@scottsand-db comments and issues resolved

vincentkoc avatar Jul 17 '22 23:07 vincentkoc

@koconder - after discussing with another engineer @vkorukanti on my team, this PR is a little bit too big to review. Could you split this up into, say, 2 or 3 smaller PRs?

scottsand-db avatar Jul 21 '22 19:07 scottsand-db

@koconder - after discussing with another engineer @vkorukanti on my team, this PR is a little bit too big to review. Could you split this up into, say, 2 or 3 smaller PRs?

May be one file per PR? Sorry, it is more work, but helps with review and testing.

vkorukanti avatar Jul 21 '22 19:07 vkorukanti

As mentioned above, we've asked that you kindly split up this PR into smaller PRs, as that will be easier to review. Closing this PR for now. Cheers.

scottsand-db avatar Aug 10 '22 03:08 scottsand-db