delta-rs icon indicating copy to clipboard operation
delta-rs copied to clipboard

feat: add enforcement for invariants to commit checker

Open hntd187 opened this issue 1 year ago • 3 comments

Description

Added invariant checking in the commit checker.

Related Issue(s)

#1568 closes #1880

Documentation

hntd187 avatar Nov 18 '23 22:11 hntd187

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

github-actions[bot] avatar Nov 18 '23 22:11 github-actions[bot]

According to the protocol invariants for 2<=>6 are always enabled, so you'd only care to check if you were 7 or higher. Are you able to disable them prior to writer feature checks?

hntd187 avatar Nov 19 '23 17:11 hntd187

Are you able to disable them prior to writer feature checks?

No, as you said, between 2 and 6 they are always enabled. The main point is that it is not an error if they are configured on the schema, so we should not error, rather if if they are not enabled, we just kind of pretend they don't exist and do nothing w.r.t. to them ...

roeap avatar Nov 22 '23 21:11 roeap

I added this in check constraints anyways so this PR isn't needed anymore.

hntd187 avatar Jan 02 '24 18:01 hntd187