bdiff

bdiff copied to clipboard

Do code review before v1.0.0 release

4

Code would benefit from a review before committing to v1 release.

delphidabbler

It's about time 64 bit versions we're created. However, the current file size limits would need to be retained.

delphidabbler

Enlarge buffer used for file reads in `TPatcher`

1

The current file read buffer size is only 4Kb - a size set back in 1999 when memory was much more scarce. This can now safely be enlarged.

delphidabbler

Check if there are limits on the value of this option. If not, maybe set low limit as 12 and upper limit as 256.

delphidabbler

Code due to be released as v1.0.0-beta lets 10MiB file size limit be overridden and be unlimited. But file format only supports sizes up to 2GiB-1. So this absolute limit...

delphidabbler

Running BDiff and BPatch v1.0.0-beta with `--version` command reports BDiff-1.0.0 2023-06-02 BPatch-1.0.0 2023-06-02 where BDiff-1.0.0-beta 2023-06-02 BPatch-1.0.0-beta 2023-06-02 were expected.

delphidabbler

BDiff & BPatch now only support Windows 7 SP1 and later, so remove the windows vista entry from both application manifest files.

delphidabbler

The line ```bat if "%VIEdRoot"=="" goto envvarerror ``` has a missing closing `%` after `%VIEdRoot`. It should be ```bat if "%VIEdRoot%"=="" goto envvarerror ```

delphidabbler

Replace the existing link with link to delphidabbler Google Drive: https://drive.google.com/file/d/1KQ3k44NFkOdSDU7-OtNi7JKVs5Mr_gt1/view This is required for 2 reasons: 1. in case the old link goes away 2. because the old is...

delphidabbler

Add new patch test using ASCII file > 64KiB

1

Using files larger than 64KiB, and preferably more than twice that size will test the newly enlarged file read buffer works with files larger than the buffer.

delphidabbler