vue3-emoji-picker icon indicating copy to clipboard operation
vue3-emoji-picker copied to clipboard

feat: add lazy loading to emoji image list

Open Vuurvos1 opened this issue 1 year ago • 2 comments

Context

Improve image loading performance by only loading images that are in view

Summary

Added loading="lazy" to emoji images in body

Relevant Technical Choices

To-do

User-facing changes

Nothing visual changes for the end user

Checklist

  • [x] I have tested this code to the best of my abilities
  • [x] I have added documentation where necessary

Fixes #17

Vuurvos1 avatar Jul 24 '23 14:07 Vuurvos1

This branch is running in CodeSandbox. Use the links below to review this PR faster.
CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

codesandbox[bot] avatar Jul 24 '23 14:07 codesandbox[bot]

Hi @Vuurvos1, Thanks so much for taking this issue;

I was thinking of adding a lazy load to the full group; for example, when smileys_people group is in the viewport, it should load all emojis for smileys_people group. Otherwise, visitors may feel a little annoyed if they need to wait to see every emoji.

Another concern is that it may not be a good idea to force lazy-loading for all images; instead we can add an option/prop like this: <EmojiPicker :lazy="true" @select="onSelectEmoji" />

delowardev avatar Jul 25 '23 16:07 delowardev