David Elner

Results 176 comments of David Elner

@igorescobar This is the current default behavior, but this comment might explain what's going on here and how to work around it: https://github.com/DataDog/dd-trace-rb/issues/277#issuecomment-527676453

@igorescobar FWIW, I feel the pain too (I think we can do better) and we are working on plans to make improvements to the default behavior; when I have more...

@MXfive It's something we'll consider expanding to other spans as well, including Excon, but isn't on the top of our docket right now. I would like to see more "span...

@dudo I think it probably makes sense that `after_request` should be invoked when some kind of exception is raised (e.g. timeout), although if that happens, its possible some of those...

Haha, I hear you @dirk! Not sure yet how the C extension thing will work out in the long run, but I'm thrilled to see this kind of PR, even...

@dirk After doing a bit of follow-up, I think we'd likely accept a C extension for this purposes. This is a very desirable feature and a C extension is likely...

I don't think this is a bug. It's likely the Rack, not the Rails span, is active, thus you're annotating its behavior instead. I would check where you're changing this...

Hey @viraptor I don't think there's much to do here; the behavior looks correct given the state of the trace when the annotation occurs. I'm going to close this one...

I'll take a look at this, see if we can merge it.

Sorry haven't had the chance yet. Will try to make some time.