David Elner
David Elner
For sure, I can understand that. I think we can have the headers you've suggested receive quantization out of the box as a default so it doesn't require as much...
Hey @jorgemanrubia, my understanding is the `RuleSampler` targets the attributes of the root span. If you're targeting a child span further down the trace, that may explain why it's not...
@marcotc May have some ideas about the sampler?
Hey @jorgemanrubia , @muzfuz. We're discussing this one with the team, figuring out how to best address it. Setting aside what the `RuleSampler` is actually doing right now, we'd like...
@tcannonfodder Per https://github.com/DataDog/dd-trace-rb/issues/2088#issuecomment-1157759367 the rules do not target child spans like `redis`, which are not the first span in the trace. I would not expect this code to work this...
@dorongutman Thanks for the report! The detail here is very rich and helpful. Looking through the repo, I suspect https://github.com/discourse/prometheus_exporter/blob/main/lib/prometheus_exporter/instrumentation/method_profiler.rb may be the issue. It does destructive `alias_method` patching, instead...
Yeah, after looking at this I arrived at the same conclusion, I think we'll have to investigate this separately.
@brettlangdon @pawelchcki I took a very hard look at this to try to come up with a way of patching `Metal` out of the box. But because of a number...
A basic Rails trace would become: 1. `rack.request` 2. `rails.action_controller.metal` (NEW) 3. `rails.action_controller` 4. `rails.render_template` In the most minimal of applications, spans 2 and 3 are expected to be of...
@pawelchcki Yup, apologize, this is definitely not ready yet. Needs tests and additional implementation. What code we have here will fix the issue, but the tests won't reflect that yet....