David Elner

ActionPack instrumentation doesn't cover `before/after_action`; this is known behavior. We wanted to add coverage for this, but the nature of how it is implemented in Rails (as an ActiveSupport notification)...

Can you clarify on the desired behavior? You want to change the `resource` on the `rails.action_controller` span from within a `before/after_action`? Generally speaking most users have preferred the controller resource...

I was going to recommend exactly what you did (renaming the trace resource). I think that should serve as an okay interim option. Generally speaking, I'd like to make the...

Yeah this is an interesting problem, from a trace model perspective. What would you expect a trace to look like? Or the latency metric to measure? If we can have...

I see. It's tricky because we need a mounting point in Rack for instrumentation to attach to, presumably with high precedence than this streaming behavior. Right now, our instrumentation is...

@dasch While I look at this, since this might be urgent on your end, I do want to offer a possible workaround using our processing pipeline. You should be able...

Although it has a broken test (which wouldn't be hard to fix), I think this would work just fine. If I may ask, if this applies to these headers, would...

@dasch It shouldn't be a significant amount using the pipeline workaround. We can certainly make it perform better still by applying the change within Rack, as we're looking to do...

If URLs then (say between the resource and `Referer`) require different quantization settings, would it require different configuration settings to match? I think introducing quantization to this tag is great,...

Yes, that's true. I'm also thinking of the case if users were to send their own custom headers containing URLs or other sensitive data.