David Elner

Results 176 comments of David Elner

@ivoanjo Totally understand how this PR can be overwhelming... it is a lot of lines changed. I think the more complicated part of all this is more in the test...

@randy-girard Thanks for the contribution! This is a good first step; I'll try to get this a thorough review in the near future. :) In the mean time, I would...

The configuration file is helpful, but I don't see anything particularly concerning in it (only some unrelated suggestions). I think I need a clearer picture of what in the existing...

I see that `active_support` service has appeared on the "after" trace, and that definitely seems wrong. But this indicates to me you're using Redis via ActiveSupport's cache API? Looking at...

Giving this another look, I think a big part of the issue may be that the resource name (provided by the Rails instrumentation) is not appropriately being set upon the...

Generally speaking, the first span in a trace determines the resource (except in certain web frameworks, where the resource name is overridden by the controller's resource name). So if you're...

@inverse @olkeene @tomasv @agrobbin @jerny-lantern FWIW, I ran some more tests of my own on this: results suggest there's no data loss between tracer and UI. Maybe there's something going...

Hey folks, I believe this one was likely fixed in 1.3.0. Since then, we've also released 1.4.1 that has another very important fix involving metrics (see #2101). I would upgrade...

The technical explanation is `ddtrace` adds instrumentation to your Rails application by adding middleware to the Rails middleware stack. This is okay to do, however certain operations in Rails or...

Ah yes, you're right @olkeene... I read the original example too hastily. `Datadog.configure` & `c.tracing.instrument :rails` must run during the initialization phase for Rails, so it can modify the Rack...