David Elner

Results 176 comments of David Elner

@muzfuz Sorry we forgot to update this. I believe this has been addressed in #2103 which added `DD_TRACE_SAMPLING_RULES`, released in 1.5.0. It's briefly mentioned as an env var here https://github.com/DataDog/dd-trace-rb/blob/master/docs/GettingStarted.md#additional-configuration...

Here's a technical description I pulled from our internal docs that may be helpful in the interim. Please let me know if this works for you. Once documentation for this...

Credit to @marcotc for adding this feature! But still happy to validate it/take your feedback if you have something to share.

@KJTsanaktsidis Right, because its the `ActionController` instrumentation that's updating the trace resource with a controller name hasn't run yet before you're raising an error. In theory, this could be done...

@KJTsanaktsidis Cool. It's a bit separate from "instrument before/after actions", so we could open that as its own feature request.

This change has been merged to `master`, pending release in 1.21.

Just trying to make sure I have a complete understanding of the change. I think the broad strokes are `TraceOperation --> TraceDigest --> Correlation::Identifier`. - `TraceDigest` is a full-copy of...

Echoing @marcotc said, but also want to say @cjubb39 the PR is already shaping up very nicely! Nice work so far :+1:

**Notes about development** There are quite a few changes here, and I think its worth segmenting them into what's a minimum, and what's additional. **Changes** - [X] Change gem from...

@ivoanjo I'm onboard with your plan. I think we were hoping to do another 1.x release to add deprecation warnings anyways, so introducing the new `ddprofrb` there would fit well....