helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Add kubelinter scans for all charts

Open mdutka-dell opened this issue 2 years ago • 4 comments

Is this a new chart?

No

What this PR does / why we need it:

Which issue(s) is this PR associated with:

  • #Issue_Number

Special notes for your reviewer:

Checklist:

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [ ] Chart Version bumped
  • [ ] Variables are documented in the chart README.md
  • [ ] Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

mdutka-dell avatar Jan 10 '24 15:01 mdutka-dell

Shouldn't we use one Kubelinter config for all charts?

cbartoszDell avatar Jan 10 '24 15:01 cbartoszDell

I group applications into three sections: csi, cosi and modules. Each section has its own KubeLinter configuration. KubeLinter supports 51 different checks, but I assume that some checks can be adequate for csi drivers and other for modules. We could also apply proposals:

  1. one kublinter config file for all charts
  2. config file per chart

mdutka-dell avatar Jan 11 '24 10:01 mdutka-dell

Hi @mdutka-dell, it looks like this PR has gone stale. Is it alright to close it?

shaynafinocchiaro avatar Apr 03 '24 13:04 shaynafinocchiaro

Hi @mdutka-dell, it looks like this PR has gone stale. Is it alright to close it?

Well, we recently discussed how to test and provide best practices to our charts. It's worth to discuss the implementation of the kubelinter.

mdutka-dell avatar Apr 04 '24 13:04 mdutka-dell

Closing PR since it has been inactive for some time. If we would like to implement kubelinter on our charts, we can reopen this PR.

shaynafinocchiaro avatar Jun 13 '24 14:06 shaynafinocchiaro