dkms icon indicating copy to clipboard operation
dkms copied to clipboard

dkms: continue on error

Open cshirron opened this issue 7 months ago • 4 comments

In the postinst script, if we hit an error building for one kernel, record the error and continue on to the next kernel. When done, exit with the value of any recorded error. This allows us to do a best-effort build for all installed kernels.

cshirron avatar May 29 '25 18:05 cshirron

I like the idea, but there should be a way to toggle this behavior (framework.conf setting, environment variable, ...). If the script is going to exit with an error, it needs to report a list of kernels where building has failed. Reading the scrollback is not feasible.

The correct synopsis prefix for the commit would be 'common.postinst:', not 'dkms:'

anbe42 avatar Jun 02 '25 09:06 anbe42

The correct synopsis prefix for the commit would be 'common.postinst:', not 'dkms:'

@anbe42 if you think we should have these guidelines in a CONTRIBUTING.md file or something similar, feel free. Currently we have no guidelines in this regard, I also don't follow this convention.

scaronni avatar Jun 02 '25 16:06 scaronni

I have taken your suggestions and made the appropriate changes.

cshirron avatar Jul 08 '25 16:07 cshirron

@cshirron sorry for the delay. Can you please make the necessary adjustments so that the pipelines pass? Thanks.

scaronni avatar Aug 08 '25 12:08 scaronni