dellemc-openmanage-ansible-modules icon indicating copy to clipboard operation
dellemc-openmanage-ansible-modules copied to clipboard

Feature: idrac_storage_volume

Open ABHISHEK-SINHA10 opened this issue 1 year ago • 1 comments

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • [ ] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • [ ] I have verified that new and existing unit tests pass locally with my changes
  • [ ] I have not allowed coverage numbers to degenerate
  • [ ] I have maintained at least 90% code coverage
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have maintained backward compatibility

ABHISHEK-SINHA10 avatar Mar 01 '24 10:03 ABHISHEK-SINHA10

Can one of the admins verify this patch?

ansible-collections-svc avatar Mar 01 '24 10:03 ansible-collections-svc

Codecov Report

Attention: Patch coverage is 98.10066% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 93.43%. Comparing base (77868f7) to head (bb0d019).

Files Patch % Lines
plugins/modules/idrac_storage_volume.py 96.19% 5 Missing and 13 partials :warning:
.../unit/plugins/modules/test_idrac_storage_volume.py 99.65% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@               Coverage Diff               @@
##           collections     #630      +/-   ##
===============================================
+ Coverage        93.26%   93.43%   +0.17%     
===============================================
  Files              195      197       +2     
  Lines            32302    33354    +1052     
  Branches          4973     5126     +153     
===============================================
+ Hits             30125    31164    +1039     
+ Misses            1332     1331       -1     
- Partials           845      859      +14     
Flag Coverage Δ
units 93.43% <98.10%> (+0.17%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 03 '24 18:03 codecov-commenter