[QUESTION]: ome_inventory.py, wrong values set?

[BilboTheGreedy]

So recently tried out the inventory plugin in AWX (dellemc.openmanage galaxy collection, latest) and noticed that idrac_ip, baseuri and hostname is filled out with exactly the same information namely the IP address of the device. This seems incorrect? Also, wouldnt it be beneficial to also include the ID of each ome device in the inventory as well if we want use ome to manage devices.

I get it that we can directly manage each inventory host directly through idrac and use idrac credentials but since it seems like a very tiny fix to the actual code to include some additional information to enable the ome playbooks which require ID for filtering specific host/device.

I noticed that in _set_host_vars we only get a string value passed through in _add_group_data which is the device_ip... wouldn't it be a better approach to send the whole host object that includes all properties to _set_host_vars instead? then hostname and baseuri could be correctly set in the inventory and adding device ID.

[anupamaloke]

@BilboTheGreedy, thank you for submitting this request. I agree that it makes sense to provide additional details such as OME device ID in addition to IP address/hostname. I have added this to the backlog.

[sachin-apa]

@BilboTheGreedy the ome_inventory plugin was introduced to run idrac modules using ome as an dynamic inventory.

idrac_ip, baseuri and hostname is filled out with exactly the same information namely the IP address of the idrac because the modules in openmanage collection has a param with different name for the host ip address input.

Adding the Serivetag, Deviceid won't help to run the idrac modules as they don't take in any of the above as input..

Can we know your use case to use this plugin for ome modules/playbools, so that we can consider right design to update this module.